jakubkulhan / bunny

Performant pure-PHP AMQP (RabbitMQ) sync/async (ReactPHP) library
MIT License
706 stars 102 forks source link

Add PHPStan to the project and CI #138

Closed realFlowControl closed 1 year ago

realFlowControl commented 1 year ago

Hey there 👋

I wanted to add a more precise definition of the callbacks passed to the Channel::consume() and Channel::run() method, when I saw that PHPStan was not in the project and I could not find any other kind of static code analysis. I would like to clean some things up (mostly adding missing types, and especially add the callback signature), so to begin with I thought it might be a good idea to bring PHPStan in the CI.

I would like to keep this PR small, so I would start adding cleanups in a separate PR, if this is okay with you.

WDYT?