search

jakubkulhan / bunny

Performant pure-PHP AMQP (RabbitMQ) sync/async (ReactPHP) library
MIT License
706 stars 102 forks source link

Promise v3 #144

Closed WyriHaximus closed 6 months ago

WyriHaximus commented 1 year ago

Resolves: #143

lookyman commented 1 year ago

I see that the failing checks on PHP 7.1 are caused by PHPStan requiring PHP 7.2. It's coming up on four years since PHP 7.1 EOL, maybe it's time to drop it?

WyriHaximus commented 1 year ago

I see that the failing checks on PHP 7.1 are caused by PHPStan requiring PHP 7.2. It's coming up on four years since PHP 7.1 EOL, maybe it's time to drop it?

In short yes, the bigger question is more do we want v3 in the 0.5 range or take it into 0.6, drop up to 8.1, and a whole bunch of changes? Having the same question in https://github.com/WyriHaximus/reactphp-throw-unhandled-rejected-promises mainly putting it at 7.1 for this package, but if we would raise it I would put 1.0.0 out with 7.1 and 1.1.0 right after with lets say 8.1

This graph is very relevant to this question: https://packagist.org/packages/bunny/bunny/php-stats#0.5

akadlec commented 1 year ago

it will be great to finish this. bunny is only package in my project which is holding me back with old promise package :/

WyriHaximus commented 1 year ago

it will be great to finish this. bunny is only package in my project which is holding me back with old promise package :/

While I agree, it is complicated. V3 handles unhandled rejections differently and I want to make sure that is taken care of well before merging and releasing this.

jakubvojacek commented 10 months ago

Any idea as to when this could be finished, please?

WyriHaximus commented 10 months ago

@jakubvojacek it's high on my list to fix. Probably going to end up doing internal updates, meaning it won't be as simple as finishing this PR. But will figure that out and then post an update.

WyriHaximus commented 6 months ago

Closed via #147, wasn't about to get this to work in 0.5, so went v3 only for 0.6 instead. Essentially #147 is the result of starting to do some internal updates 😅 .