search

jakubnabrdalik / hentai

Example of Hexagonal architecture with high cohesion modularization, CQRS and fast BDD tests in Java
Apache License 2.0
220 stars 51 forks source link

Shouldn't FilmFacade constructor be package private? #7

Open mkrzywanski opened 3 years ago

mkrzywanski commented 3 years ago

Just a simple question. Shouldn't FilmFacade constructor be defined as package private? Right now it is defined as public but client code cannot instantiate it with it because it's dependencies are package private so client code (for example in different package) cannot use it. It can be instantiated only by using Spring and having FilmConfiguration class scanned.

jakubnabrdalik commented 3 years ago

You are correct, that should be package scoped. Perhaps I should update this sample project.

mkrzywanski commented 3 years ago

I can file a PR for this simple change if you want.

jakubnabrdalik commented 3 years ago

If you'd like to, sure, but I'm thinking about updating the whole thing to a more up-to-date version (I implement these requirements live a few time every year).