search

jakubpawlowicz / assets-packager

Assets pipeline for ultra fast CSS and JavaScript packaging.
MIT License
44 stars 9 forks source link

handle process callback #24

Open suruja opened 10 years ago

suruja commented 10 years ago

Hello!

I want to use your project as a node module, and I need a callback to know when processing ends. I just add a callback to your async.series call in process function.

GoalSmashers commented 10 years ago

I've never had a chance to use it programatically. Would you be able to provide a test for this feature so I can merge it?

suruja commented 10 years ago

The callback I added to async.series is used and tested in async module itself, and the assets-packager tests suite still pass with this minor change. Do you think a new test is necessary?

jakubpawlowicz commented 10 years ago

It would be great to have one but there is even no skeleton for non-binary tests. Let me add it first.