search

jakubrohleder / angular-jsonapi

Simple and lightweight, yet powerful ORM for your frontend that seamlessly integrates with your JsonAPI server.
http://jakubrohleder.github.io/angular-jsonapi/
GNU General Public License v3.0
95 stars 34 forks source link

Fixes for some of the issues I have listed before #6

Closed hedder closed 9 years ago

hedder commented 9 years ago

Please review it

jakubrohleder commented 9 years ago

Please keep PR separated: one issue = one PR.

Some fixes are great, but:

5 fix should also be added to resource.get as well.

4 should not remove id validation. Moreover even new objects are now stored in the cache (yeah, bad idea) and are updated after add synchronization (resource.factory.js:166). As you remove local id generation the flow breaks. This issue needs a little bit more work.