search

jakubsuchy / brightcove_drupal

Brightcove integration with Drupal
http://drupal.org/project/brightcove
7 stars 0 forks source link

Echove is checked only during first installation #2

Open Cellane opened 14 years ago

Cellane commented 14 years ago

It seems that hook_requirements() checks whether Echove is installed or not only during first installation, but not after Brightcove module is disabled and re-enabled.

jakubsuchy commented 14 years ago

hook_requirements are not limited to install, there is runtime too. Can you check that you don't see a big status error if you are missing echove during runtime?

Cellane commented 14 years ago

Hm. I disabled Brightcove module, renamed echove.php to echoveabc.php, then re-enabled Brightcove. This was completed without any error message. The only error message appears on /admin page, displaying "One or more problems were detected with your Drupal installation. Check the status report for more information." message.

I think presence of Echove should be checked when administrator chooses to enable previously installed and later disabled Brightcove module, if that's possible.

jakubsuchy commented 14 years ago

I am not sure if this is possible. Probably yes using hook_enable, postponing for now