search

jakweg / Mobishit

Alternatywna aplikacja do dziennika mobireg
https://jakub.wegrzyn.dev/pl/mobishit
5 stars 2 forks source link

Add language selection #5

Closed jakub-gonet closed 5 years ago

jakub-gonet commented 6 years ago

I think adding English language could be useful. This doesn't have high priority though.

jakweg commented 6 years ago

Personally I don't think English language is needed. The app has been coded to be "polish-only", almost all strings are hardcoded into the code, therefore adding translations would need refactoring every file. How about strings form database for example subject's names? Should we leave them in polish or hardcode English translations?

jakub-gonet commented 6 years ago

I see your point. Yeah, I'll agree about focus on mostly polish community, so refactoring it to use English naming wouldn't be really necessary. I think this issue can be closed.