search

jalaali / jalaali-js

JavaScript functions for converting Jalaali and Gregorian calendar systems to each other
MIT License
310 stars 36 forks source link

updated #10

Closed Xaus closed 6 years ago

Xaus commented 6 years ago

+convertTimeStampToJalaliDate : converts mysql timestamp to jalali date +convertTimeStampToTime : converts mysql timestamp to normal time +linting

behrang commented 6 years ago

Hey, thanks for the contribution, but you have changed every line of code, which is not a good practice for a pull request. You should have just added those two functions.

Those two functions are also utility functions that are not that useful for this project. A user could easily convert timestamp to a Date object and then convert that to Jalaali using conversion functions.