Clean code and update dev dependencies

jalaali / jalaali-js

JavaScript functions for converting Jalaali and Gregorian calendar systems to each other

MIT License

310 stars 36 forks source link

Clean code and update dev dependencies #15

Closed behnammodi closed 5 years ago

behnammodi commented 5 years ago

All test is ok

behrang commented 5 years ago

I don't get the reason for this change. You have also removed a field from the return value. Also another if statement is added. Why?

behnammodi commented 5 years ago

@behrang Thank you for review code 1- No added new if and just replaced 2- This field unused when withoutLeap is true 3- I used multi exit points for readability

behrang commented 5 years ago

Ok, merged. Thanks.

behnammodi commented 5 years ago

You’re welcome