search

jalaali / jalaali-js

JavaScript functions for converting Jalaali and Gregorian calendar systems to each other
MIT License
307 stars 36 forks source link

methods return array #43

Closed AhmadMrf closed 1 year ago

AhmadMrf commented 1 year ago

methods return array instead of object , for easier destructuring

jalaali.toJalaali(2016, 4, 11) // [1395, 1, 23 ]
jalaali.toGregorian(1395, 1, 23) // [ 2016, 4, 11 ]
jalaali.jalaaliWeek(1400, 4, 30) // { saturday: [ 1400,  4,  26 ], friday: [ 1400,  5, 1 ] }
let [year, month, day] = jalaali.toJalaali(2016, 4, 11)
behrang commented 1 year ago

Hey, thanks for the pull request. However, this change breaks users' code that is already using these functions. So, I have to reject it.