search

jalaali / moment-jalaali

A Jalaali (Jalali, Persian, Khorshidi, Shamsi) calendar system plugin for moment.js.
MIT License
940 stars 162 forks source link

Es6 Is not supporet #245

Open timsar2 opened 1 year ago

timsar2 commented 1 year ago

Es6 is not supported. this package is dependent on CommonJS or AMD. that can cause optimization bailouts when bundling modern javascript. https://web.dev/commonjs-larger-bundles/

behrang commented 1 year ago

You're right, but what's your proposal? I think this project is getting retired and it's better to not make a big change like this.

HoseinGhanbari commented 1 year ago

It would be great if we can upgrade the package in order to make it compatible with modern javascript. According to angular.io It is recommended that you avoid depending on CommonJS modules in your Angular applications as

CommonJS or AMD dependencies can cause optimization bailouts