jalaali / moment-jalaali

A Jalaali (Jalali, Persian, Khorshidi, Shamsi) calendar system plugin for moment.js.
MIT License
940 stars 162 forks source link

Adding Persian/Dari and pashto #249

Closed mahdiataey closed 1 year ago

mahdiataey commented 1 year ago

This is a great and useful for developers to have persain-dari and pashto in their calendars, I added it, please kindly accept it and rebuild it on npm. Thank you

behrang commented 1 year ago

Great. Thanks.

behrang commented 1 year ago

Version 0.10.0 released.

mahdiataey commented 1 year ago

Thank you so much! I want to add 2 more for extend function but I'm not pretty sure about the usage. You kindly tell me the extend where they are used. If I understand I will add it. Cencerly, Mahdy Ataey,

On Sat, Apr 15, 2023, 10:18 AM Behrang Norouzinia @.***> wrote:

Version 0.10.0 released.

— Reply to this email directly, view it on GitHub https://github.com/jalaali/moment-jalaali/pull/249#issuecomment-1509548127, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIZVAI44IKCM3YMZIUYPHM3XBIZDPANCNFSM6AAAAAAW57HSZM . You are receiving this because you authored the thread.Message ID: @.***>

behrang commented 1 year ago

I don't understand the question. Please explain more.

mahdiataey commented 1 year ago

I don't understand the question. Please explain more. this part:

extend(getPrototypeOf(moment.localeData()), { _jMonths: [ 'Farvardin' , 'Ordibehesht' , 'Khordaad' , 'Tir' , 'Amordaad' , 'Shahrivar' , 'Mehr' , 'Aabaan' , 'Aazar' , 'Dey' , 'Bahman' , 'Esfand' ] , jMonths: function (m) { return this._jMonths[m.jMonth()] }

, _jMonthsShort: [ 'Far' , 'Ord' , 'Kho' , 'Tir' , 'Amo' , 'Sha' , 'Meh' , 'Aab' , 'Aaz' , 'Dey' , 'Bah' , 'Esf' ] ,

behrang commented 1 year ago

These are the full names and short names (3 letter) of Persian months, in English.

mahdiataey commented 1 year ago

Thank you sir for your response I want to add 2 more interfaces in @types/moment-jalaali but the it does not merge and fails kindly help me to adding it in index.dt.ts --> DefinitelyTyped/index.d.ts at master · DefinitelyTyped/DefinitelyTyped (github.com) https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/moment-jalaali/index.d.ts during the npm test all it fails I want to change like this: moment-jalaali[types]: add 2 more interfaces and functions in index.d.ts by mahdiataey · Pull Request #65146 · DefinitelyTyped/DefinitelyTyped (github.com) https://github.com/DefinitelyTyped/DefinitelyTyped/pull/65146/commits/9914412bed2e33e4939ea2a1ce12405916be3c55

On Sat, Apr 15, 2023 at 8:20 PM Behrang Norouzinia @.***> wrote:

These are the full names and short names (3 letter) of Persian months, in English.

— Reply to this email directly, view it on GitHub https://github.com/jalaali/moment-jalaali/pull/249#issuecomment-1509876035, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIZVAIY7SZYNEJ43IAQDXHTXBK7SXANCNFSM6AAAAAAW57HSZM . You are receiving this because you authored the thread.Message ID: @.***>

behrang commented 1 year ago

I'm not familiar with TypeScript, and can't help here, but maybe @alitaheri can help with this.