jalagar / animated-art-engine

A generative engine that takes various png layers on a sprite sheet format, combines them and then converts them into a .gif file
MIT License
166 stars 64 forks source link

No GIF export #192

Open Marlick opened 8 months ago

Marlick commented 8 months ago

Hi, the code works good for me I have installed all the requirements and Gifski is installed but when I command "make all" everything works normal but in output there is no GIF file and also there is no error

I'm using windows: 11 node.js: v16.14.2 Python: 3.12.1 Pillow: v10.1.0 Gifsky: v1.13.0

jalagar commented 8 months ago

Hi there @Marlick try add debug true in the json and see if there are any errors

peppss77 commented 8 months ago

Hi @Marlick and @jalagar !

i have the same issue as you Marlick! but later i found out that there is some code that miss in position, you have to open build.py in step3_generative_sheet_to_output and look out at line 183. after that, you can copy and paste this one at line 183 - 196 (change the previous) and i think it will works for you too:

def generate_gif_gifski( output_directory, temp_img_folder, gif_name, gif_width, gif_height, kwargs ): subprocess.run( f"gifski -o {os.path.join(output_directory, gif_name)} " f"-r={fps} " f"-Q={quality} " f"-W={gif_width} " f"-H={gif_height} " f"--repeat={0 if loop_gif else -1} " f"{temp_img_folder}/*.png ", shell=True, **kwargs, )

SkyYap commented 8 months ago

Hi @Marlick and @jalagar !

i have the same issue as you Marlick! but later i found out that there is some code that miss in position, you have to open build.py in step3_generative_sheet_to_output and look out at line 183. after that, you can copy and paste this one at line 183 - 196 (change the previous) and i think it will works for you too:

def generate_gif_gifski( output_directory, temp_img_folder, gif_name, gif_width, gif_height, kwargs ): subprocess.run( f"gifski -o {os.path.join(output_directory, gif_name)} " f"-r={fps} " f"-Q={quality} " f"-W={gif_width} " f"-H={gif_height} " f"--repeat={0 if loop_gif else -1} " f"{temp_img_folder}/*.png ", shell=True, **kwargs, )

I try to change the line 183 - 196 code to your provided code and it still doesn't work. Any direction I can do to find the debug log?

peppss77 commented 8 months ago

you can add --debug after the command

SkyYap commented 8 months ago

you can add --debug after the command

PS C:\Users\SkyYap\Documents\GitHub\animated-art-engine> make all --debug

GNU Make 4.4.1
Built for Windows32
Copyright (C) 1988-2023 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <https://gnu.org/licenses/gpl.html>
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.
Reading makefiles...
Updating makefiles....
Updating goal targets....
 File 'all' does not exist.
Must remake target 'all'.
python3 all.py
********CREATING INITIAL JSON*******
********Starting step 1: Converting pngs to spritesheets********
Parsing layer folder Background
Parsing attributes in folder: Dark Blue#20
Parsing attributes in folder: Green#20
Parsing attributes in folder: Grey#20
Parsing attributes in folder: Light Blue#20
Parsing attributes in folder: Multicolor#1
Parsing attributes in folder: Orange#20
Parsing attributes in folder: Pink#20
Parsing attributes in folder: Yellow#20
Parsing layer folder Ball
Parsing attributes in folder: Blue#20
Parsing attributes in folder: Green#20
Parsing attributes in folder: Multicolor#1
Parsing attributes in folder: Orange#20
Parsing attributes in folder: Pink#20
Parsing attributes in folder: Purple#20
Parsing attributes in folder: Red#20
Parsing attributes in folder: Yellow#20
Parsing layer folder Hat
Parsing attributes in folder: Birthday#20
Parsing attributes in folder: Cowboy#20
Parsing attributes in folder: Green Square#5
Parsing attributes in folder: Mini Ball#1
Parsing attributes in folder: None#50
Parsing attributes in folder: Top Hat#20
Parsing attributes in folder: White Cap#20
Parsing attributes in folder: Wizard#1
Parsing layer folder Landscape
Parsing attributes in folder: Cupcake#10
Parsing attributes in folder: Face#20
Parsing attributes in folder: Goldfish#20
Parsing attributes in folder: Green Tower#30
Parsing attributes in folder: Mountain#20
Parsing attributes in folder: None#20
Parsing attributes in folder: Red Tower#30

> nft-animated-generator@3.1.3 generate
> node index.js 1 1

(node:23352) [DEP0147] DeprecationWarning: In future versions of Node.js, fs.rmdir(path, { recursive: true }) will be removed. Use fs.rm(path, { recursive: true }) instead
(Use `node --trace-deprecation ...` to show where the warning was created)
Created edition: 0, with DNA: 1c921a817eb651d707e4ae8412bb7754e0b6f1223788d87339b8eb2b7fffdb3c
Created edition: 1, with DNA: 42d51bbd5c9c7c4544c14d919b9ddfcbfd7c6ce660d61faff5a9bd519dcf137b
Created edition: 2, with DNA: 4dbd3ad313f8025e2d9459b5c73d800f315ef3c42194b128a00b33977a712c35
Created edition: 3, with DNA: e94fc8fff1048e42183192466acef13329c50ef8593e20fc893885941b1bd01b
********STARTING REGENERATION PROCESS*******
********Starting step 1: Converting pngs to spritesheets********
Parsing layer folder Background
Parsing attributes in folder: Dark Blue#20
Parsing attributes in folder: Green#20
Parsing attributes in folder: Grey#20
Parsing attributes in folder: Light Blue#20
Parsing attributes in folder: Multicolor#1
Parsing attributes in folder: Orange#20
Parsing attributes in folder: Pink#20
Parsing attributes in folder: Yellow#20
Parsing layer folder Ball
Parsing attributes in folder: Blue#20
Parsing attributes in folder: Green#20
Parsing attributes in folder: Multicolor#1
Parsing attributes in folder: Orange#20
Parsing attributes in folder: Pink#20
Parsing attributes in folder: Purple#20
Parsing attributes in folder: Red#20
Parsing attributes in folder: Yellow#20
Parsing layer folder Hat
Parsing attributes in folder: Birthday#20
Parsing attributes in folder: Cowboy#20
Parsing attributes in folder: Green Square#5
Parsing attributes in folder: Mini Ball#1
Parsing attributes in folder: None#50
Parsing attributes in folder: Top Hat#20
Parsing attributes in folder: White Cap#20
Parsing attributes in folder: Wizard#1
Parsing layer folder Landscape
Parsing attributes in folder: Cupcake#10
Parsing attributes in folder: Face#20
Parsing attributes in folder: Goldfish#20
Parsing attributes in folder: Green Tower#30
Parsing attributes in folder: Mountain#20
Parsing attributes in folder: None#20
Parsing attributes in folder: Red Tower#30

> nft-animated-generator@3.1.3 create_from_dna
> node utils/createFromDNA.js 0 12000

> nft-animated-generator@3.1.3 create_from_dna
> node utils/createFromDNA.js 1 12000

> nft-animated-generator@3.1.3 create_from_dna
> node utils/createFromDNA.js 2 12000

> nft-animated-generator@3.1.3 create_from_dna
> node utils/createFromDNA.js 3 12000

Starting step 3: Converting sprite sheets to gif
Converting spritesheet to gif for 0.png
Converting spritesheet to gif for 1.png
Converting spritesheet to gif for 2.png
Converting spritesheet to gif for 3.png
Successfully remade target file 'all'.

No special instruction was shown and yet the build/gif

NFTlancer commented 5 months ago

Same issue, any solution?

SkyYap commented 5 months ago

Same issue, any solution?

still facing the same issue.