Closed litanlitudan closed 2 years ago
I think that the intent of the code is correct. As you can see in the changes introduced by version 4.13 of the transformers lib (you can check those in this comparison with the previous version) the expected input of the function (_prepare_decoder_input_ids_for_generation
in the src/transformers/generation_utils.py
file) indeed changes from a tensor to an int.
But what I think causes this error (I also had it) is that the execution is wrong. As the code is just comparing strings, we have for e.g. "4.6.1" > "4.13".
I opened a PR that I believe solves this: https://github.com/jalammar/ecco/pull/62
Thanks! Indeed fixed with #62.
Hi Jay,
Thanks for the great tool that you built. I was playing around with it and ran into the following error on the T5-small example from readme.
Here is the example code I was playing with
After some debugging, I realized that the hotfix for T5 generation from previous commits might not be need. But I am not sure starting which exact version of transformers don't need this hack, so I thought it might be a good idea to file a quick PR for this to bring up attention.