search

jalapic / engsoccerdata

English and European soccer results 1871-2022
755 stars 192 forks source link

England_current() returns same column names but different column types #48

Closed padpadpadpad closed 3 years ago

padpadpadpad commented 6 years ago
  1. Fantastic package!
  2. england_current() returns the same column names as in data(england), but the column types are different. For example, division is numeric whereas it is a character in data(england).

This causes an error when trying to bind these rows with dplyr::bind_rows().

Would work much better if these were all the same. Either all characters or numeric.

jalapic commented 6 years ago

thanks - that's a bug. Previously they were all the same. I will fix as soon as I get a chance.

jalapic commented 3 years ago

I fixed this a while ago - just closing this now. Should work for all European leagues.