Improve BVH construction, vastly improve performance, misc bug fixes

jalberse / shimmer

Physically based rendering in Rust

Apache License 2.0

33 stars 0 forks source link

Improve BVH construction, vastly improve performance, misc bug fixes #54

Closed jalberse closed 4 months ago

jalberse commented 4 months ago

Fixed BVH node bounds calculations, which vastly improves performance. Had used zero as the start for the BVH bounds accumulator; should have used the default, which uses MAX/MIN for the min/max of the bounds respectively, which allows unions to properly accumulate. I fixed this bug in a different spot in a previous commit, but missed it here.

Performance is now on par with PBRTv4.

Also includes some minor bug fixes related to camera construction.

jalberse commented 4 months ago

It turns out that I didn't actually include that fix in this pull request... I must have stashed that change. I've fixed it again and I am pushing