search

jalcine / cmake.vim

:hammer: CMake functionality within Vim.
https://jalcine.github.io/cmake.vim
MIT License
74 stars 11 forks source link

Use internal variable to check for vim-dispatch #17

Closed richjoyce closed 10 years ago

richjoyce commented 10 years ago

CMakeCreateBuild will fail without vim-dispatch installed with the following error. It seems it was set up to fix this by setting g:cmake_use_dispatch on load, but the code didn't use the internal variable.

[cmake] Configuring project for the first time...
Error detected while processing function cmake#commands#create_build..cmake#util
#run_cmake..cmake#util#shell_exec:
line    1:
E121: Undefined variable: g:loaded_dispatch
E15: Invalid expression: g:loaded_dispatch == 1
tarc commented 10 years ago

I was nearly giving up using this plugin due the above error. The above patch fixed the CMakeCreateBuild for me, but still can't use no other command except this one (I have vimux and ycm installed).

richjoyce commented 10 years ago

Yeah I have this issue too actually. I couldn't find what was causing it and gave up for now. This plugin is promising, but as warned by the author is still very alpha.

jalcine commented 10 years ago

I really thought I replaced this before! :crying_cat_face: Thanks for the PR!

jalcine commented 10 years ago

Hey @richjoyce and @tarc; can you guys confirm that this doesn't exist in master? I'm looking to build a test suite for this plugin; and this would be the first regression test, I'd love to get feedback!

tarc commented 10 years ago

Well, for me it's still there. Checking the git history it seems that the bug slipped inside again in 0935ba67

tarc commented 10 years ago

Well, forget about my previous comment on the git history - you applied the patch after that revision. But anyway I still got the same error (using branch master).

jalcine commented 10 years ago

It's weird, I run into this after updating my dispatch plug-in. I have a patch, using Ex commands, won't be able to push until the morning in New York.

jalcine commented 10 years ago

I'm working on building out the test suite (as per #19); and should have it down soon. I still didn't get to push those changes yet; but they'll be on develop. I'll let you know when I have.