jalensailin / mvrpg

MIT License
2 stars 0 forks source link

Math damage is off? #10

Closed fougerec closed 5 months ago

fougerec commented 5 months ago

image Not sure what's going on here

Marvel die is 2 Melee Modifier is x1 Melee Bonus is 3

Showing damage as 4 instead of 5

fougerec commented 5 months ago

image In this one

1st example Marvel die is a 5 Melee Modifier is 1 Melee Modifier is 1

Showing damage as 7 instead of 6

Example 2 Marvel die is M Melee Multiplier is 1 Melee modifier is 1

Showing damage as 16 instead of 14.

jalensailin commented 5 months ago

This is all quite odd. I will look into it

jalensailin commented 5 months ago

This is very strange and I am not yet able to replicate it. Can you give me precise steps to reproduce the issue?

fougerec commented 5 months ago

I made a character (using the SHIELD Agent stats) and rolled a Melee attack and then rolled damage. That was it, nothing fancy.

When I make a new character with everything at default it works.

Adding some points into things and it still works. The other three characters though have wonky math on the melee and don't seem to be picking up the Damage Multiplier.

I'll generate some more characters tomorrow, including completely replicating the ones that aren't adding up right and see what happens.

jalensailin commented 5 months ago

were you ever able to confirm this on a fresh actor?

fougerec commented 5 months ago

It works fine on a fresh actor. I've tried replicating different things - adding to the combat tracker, removing them, adding them back, rolling initiative, running a full mock combat etc. The original two characters I made are still borked but the two new ones work fine.

jalensailin commented 5 months ago

if its working as expected on a fresh actor, then I think we are good to close this issue :). i likely changed something in the datamodel that the old actors were relying on