search

jaliss / securesocial

A module that provides OAuth, OAuth2 and OpenID authentication for Play Framework applications
http://www.securesocial.ws
Apache License 2.0
1.19k stars 510 forks source link

Event: Sealed Trait doesn't allow custom events #530

Closed nightrise closed 9 years ago

nightrise commented 9 years ago

Hi jaliss,

I wanted to add a custom event to track email changes, but sadly it seems like it isn't possible to extend the "Event" class outside the actual file it's defined due to it being marked as "sealed".

Is there a practical or security reason for this? It would be very nice to be able to add however many custom events and react to them via the EventListener.

jaliss commented 9 years ago

You are right @nightrise. It would be much useful not to have a sealed trait.

jaliss commented 9 years ago

just added this to master. Thanks for the suggestion @nightrise