search

jaliss / securesocial

A module that provides OAuth, OAuth2 and OpenID authentication for Play Framework applications
http://www.securesocial.ws
Apache License 2.0
1.19k stars 511 forks source link

Support Play 2.6 #611

Closed kubukoz closed 6 years ago

kubukoz commented 7 years ago

Play 2.6 is out, it'd be worth checking if it's compatible with the current release and documenting it (the homepage still says "Supports Play versions 2.1.x, 2.0.x and 1.x"), and, if needed, making it so.

normenmueller commented 6 years ago

Yes, please open a branch for Play 2.6. For example

class MyController @Inject()(
  override implicit val env: MyEnvironment,
  cc: ControllerComponents
) extends AbstractController(cc)
  with securesocial.core.SecureSocial { ... }

causes

[error]   method parse in trait BaseControllerHelpers of type => play.api.mvc.PlayBodyParsers  and
[error]   lazy value parse in trait BodyParsers of type play.api.mvc.PlayBodyParsers
gmethvin commented 6 years ago

Working on this in #614. Feedback appreciated.