Don't strip CSS comment hacks

jalmenarez / minify

Automatically exported from code.google.com/p/minify

BSD 3-Clause "New" or "Revised" License

0 stars 0 forks source link

Don't strip CSS comment hacks #3

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago

Oddly-formatted CSS comments are sometimes used as hacks, since certain
browsers don't parse them correctly. Such comments should be identified and
left in if possible.

http://www.quirksmode.org/css/csshacks.html

Original issue reported on code.google.com by rgr...@gmail.com on 4 May 2007 at 3:50

GoogleCodeExporter commented 9 years ago

Original comment by rgr...@gmail.com on 4 May 2007 at 3:51

Added labels: Milestone-Release-1.0.1
Removed labels: Milestone-Release1.0.1

GoogleCodeExporter commented 9 years ago

Changing to low priority, since the CSS comment hacks I'm aware of are only 
useful
with old, long-abandoned browsers and as such probably aren't widely used 
anymore.

Original comment by rgr...@gmail.com on 4 May 2007 at 4:02

Added labels: Priority-Low
Removed labels: Milestone-Release-1.0.1, Priority-Medium

GoogleCodeExporter commented 9 years ago

v2's Minify_CSS class is passing several test cases with hacks:

http://code.google.com/p/minify/source/browse/trunk/web/test/css/

subsilver.css was chosen as a real-world usage scenario, but more testing is
certainly needed.

Original comment by mrclay....@gmail.com on 29 Feb 2008 at 12:56

Changed state: Started
Added labels: Priority-Medium
Removed labels: Priority-Low

GoogleCodeExporter commented 9 years ago

R82 verifies BMH and MSIE filters are left intact.

Original comment by mrclay....@gmail.com on 14 May 2008 at 4:16

Changed state: Fixed