Minify_groupUri() not working and no way to remove querystrings from generated URIs.

[GoogleCodeExporter]

Minify version: 2.1
PHP version: 5.2.6

Great job, guys! I love this project.

I noticed a couple issues installing your latest release. I'm not sure of
common bug reporting protocol but here's what I noticed ....

1) in utils.php
 static $cg = false; 
should be
 static $gc = false;
2) the current README.txt references util.php not utils.php
3) in Build.php
 require_once 'Minify/Source.php';
should be
 require_once 'Source.php';
4) groupsConfig.php lacked a closing ?>
5) My understanding is that URL's with query strings (e.g. /min/?TIMESTAMP)
aren't supposed to be cached even if the query is the same (although IE &
FF ignore this, but others may not). Maybe there's a mod_rewrite option
that could avoid this.

Thanks!

Original issue reported on code.google.com by Keith.Be...@gmail.com on 5 Oct 2008 at 6:25

[GoogleCodeExporter]

re 4) oh, i see that's how you're ending all of the pages :P

Original comment by Keith.Be...@gmail.com on 5 Oct 2008 at 6:38

[GoogleCodeExporter]

1+2) Fixed in R249. Thanks for that catch.
3) It's correct as is.
5) Querystring URLs sent with Expires are indeed cached by all browsers and 
this is 
according to spec. The [http://www.stevesouders.com/blog/2008/08/23/revving-
filenames-dont-use-querystring/ limitation] is with the proxy Squid in its 
default 
configuration.
Right now Javascript in the builder app detects whether mod_rewrite works, but 
there's no direct way to get this info to Minify_groupUri(). I guess I need to 
add a 
another config option.

Original comment by mrclay....@gmail.com on 5 Oct 2008 at 10:53

• Changed state: Fixed

[GoogleCodeExporter]

R250 allows the removal of querystrings from generated URIs (set 
$forceAmpersand to 
true in Minify_groupUri) and makes it clearer that min/lib needs to be in the 
include_path before utils.php is included. I'd forgotten that Build.php 
required 
Source.php.

Original comment by mrclay....@gmail.com on 5 Oct 2008 at 11:47

• Changed title: Minify_groupUri() not working and no way to remove querystrings from generated URIs.
• Changed state: Verified

[GoogleCodeExporter]

re 3) with "Minify/Source.php", I get:

Warning: require_once(Minify/Source.php) [function.require-once]: failed to open
stream: No such file or directory in [omitted]/min/lib/Minify/Build.php on line 
7

Fatal error: require_once() [function.require]: Failed opening required
'Minify/Source.php' (include_path='.:/usr/lib/php:/usr/local/lib/php') in
[omitted]/min/lib/Minify/Build.php on line 7

It appears that it's not included in my path.

After a little exploring, I see that you have $min_libPath in config.php and 
that you
set the include path in index.php, but it looks like Build.php is required only 
in
utils.php, and utils.php is only called before index.php is referenced by the 
HTML
source.

So it seems, at least in my situation as per the README where I noticed util.php
should be utils.php, it's not in the path (at least, until later)...

Original comment by Keith.Be...@gmail.com on 5 Oct 2008 at 11:50

[GoogleCodeExporter]

lol ... we were probably writing that at the same time.

Original comment by Keith.Be...@gmail.com on 5 Oct 2008 at 11:52

[GoogleCodeExporter]

OK :) Just to finish this issue, could you copy utils.php, Build.php from R250 
and 
verify that utils.php loads and Minify_groupUri() works for you as long as you 
add /
min/lib to your include_path beforehand?

Original comment by mrclay....@gmail.com on 6 Oct 2008 at 11:59

[GoogleCodeExporter]

Original comment by mrclay....@gmail.com on 7 Oct 2008 at 3:36

• Added labels: Release-2.1.0