search

jalmenarez / minify

Automatically exported from code.google.com/p/minify
BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

minmax.js does not get minfied #9

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
1. I use minmax.js (http://www.doxdesk.com/software/js/minmax.html) on my
site and minify.php to minify the js. But it does not seem to work with
this file. All my other css works fine.

Original issue reported on code.google.com by j...@jedisthlm.com on 20 May 2007 at 10:24

Attachments:

GoogleCodeExporter commented 9 years ago 
JSMin, which Minify uses to compress JS, only works with valid JavaScript. The
minmax.js file you attached contains JScript conditional comments, which are an
invalid Microsoft extension to JS supported only by IE. As a result, the entire
script is treated as a comment by standards-compliant JavaScript parsers.

Original comment by rgr...@gmail.com on 28 Aug 2007 at 5:17

GoogleCodeExporter commented 9 years ago 
Version 2.1+ won't *break* the file, but won't minify it either (it ignores but 
does 
not delete Jscript conditional comments).

FWIW this file is bad practice now (IE7+ doesn't need it) and it encouraged a 
bad 
design (should be conditionally linked in the HTML so only IE requested it).

Original comment by mrclay....@gmail.com on 27 Nov 2008 at 3:31

GoogleCodeExporter commented 9 years ago 
thanks!

Original comment by j...@jedisthlm.com on 27 Nov 2008 at 4:10