search

jalmeroth / homie-python

A Python-implementation of the homie v2 convention.
https://github.com/marvinroger/homie
54 stars 15 forks source link

Homie 2 #32

Closed sja closed 6 years ago

sja commented 7 years ago

I tried to fullfill the Homie 2 convention. I have no clue about Python, so any suggestion would be helpful.

sja commented 7 years ago

Ok, now I saw your dev branch. Damn.

The only solution my approach has better than yours: I determine the local mac address from the real used network interface which is used to connect to the broker. Maybe that's something you find useful.

jalmeroth commented 7 years ago

@sja thanks for your contribution! I see you have invested quite some effort for this PR, but as the dev branch holds a lot of changes towards homie v2, I am honestly not so sure how to handle this situation best. In any case, I will need some time to review your changes, maybe I will cherry-pick some code, if that would be ok with you?

sja commented 7 years ago

Thats totally ok! I just made an approach which does not fullfill the complete convention. Feel free to close this PR.

Freundliche Grüße Sebastian Janzen

Am 24.06.2017 um 22:13 schrieb Jan Almeroth notifications@github.com:

@sja thanks for your contribution! I see you have invested quite some effort for this PR, but as the dev branch holds a lot of changes towards homie v2, I am honestly not so sure how to handle this situation best. In any case, I will need some time to review your changes, maybe I will cherry-pick some code, if that would be ok with you?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

jalmeroth commented 6 years ago

PR was integrated via bc602b12a2a49c18566e552a05b7c32232f0513b