search

jalogut / magento2-deployer-plus

Tool based on deployer.org to perform zero downtime deployments of Magento 2 projects
GNU General Public License v3.0
200 stars 59 forks source link

Add `dereference` flag to tar command #25

Closed renttek closed 5 years ago

renttek commented 6 years ago

The -h flag will tell tar to dereference symlinks and archive the files instead of the symlink.

This way it is possible to have symlinked composer packages (path-repositories) outside of the magento root and still build an full release artifact.

jalogut commented 6 years ago

Hi @renttek

Thanks for your PR. Unfortunately I do not think that this should be the default behaviour. If you need that, you can overwrite that function in your project deploy.php file by adding:

task('artifact:package', 'tar --exclude-from={{artifact_excludes_file}} -chzf {{artifact_path}} .');

Would that be ok for you?

renttek commented 6 years ago

Hi @jalogut

yeah thats absolutely okay. Maybe this could be a part of the troubleshooting-part in the readme?

jalogut commented 6 years ago

Hi @renttek

Yes, that would be nice. Would you mind updating this PR with the info in the troubleshooting instead? A copy paste from your first comment should be enough.