jalogut / magento2-deployer-plus

Tool based on deployer.org to perform zero downtime deployments of Magento 2 projects
GNU General Public License v3.0
200 stars 60 forks source link

Deployment fails with upgrade to symfony/console version 5 #46

Closed wilfriedwolf closed 4 years ago

wilfriedwolf commented 4 years ago

With the upgrade to symfony/console from 4.1.11 to 4.1.12 magento2-deployer-plus will fail, because of the type declaration introduced there and the missing description in magento2-deployer-plus.

/**
     * Sets the description for the command.
     *
     * @return $this
     */
    public function setDescription(string $description)
    {
        $this->description = $description;
        return $this;
    }

I'll do a pull request in a while...

Best regards, Willi

piotrkwiecinski commented 4 years ago

This is an issue with deployer itself: https://github.com/deployphp/deployer/compare/v6.7.1...master

There some fixes literally from today :)

piotrkwiecinski commented 4 years ago

Just in case if it's a blocker for anyone as a temporary workaround you can lock version of deployer in composer.json to: "deployer/dist": "<6.7"

wilfriedwolf commented 4 years ago

Oh, ok. I thought, deployer would now require a description. I'll close the issue then..