search

jalvesaq / zotcite

Neovim plugin for integration with Zotero
GNU General Public License v3.0
159 stars 13 forks source link

new remap to extract abstract #83

Closed adam-coates closed 1 month ago

adam-coates commented 1 month ago

Here I have edited the docs for the new <leader>zb keymap and I have made a new function PasteAbstractNote in get.lua that gets the abstract as a string to paste into the current buffer.

I am not sure if the mapping :ZextractAbstract is completely correct though and here this might need a bit of tweaking.

jalvesaq commented 1 month ago

It works! Good job!

I only think that it would be better if the function name followed the same implicit convention of other functions from the get.lua module. That is, instead of zotcite.get.PasteAbstractNote it could be zotcite.get.abstract. It seems strange to me to read "get paste" and, although "note" is part of the label in the sqlite database, I prefer short names, unless the longer name adds meaningful precision.

adam-coates commented 1 month ago

Great, I'm glad! I'm happy to change the name of the function, to follow the same convention. True that get.Paste... doesn't make a whole lot of sense.

I'm also thinking a bit about other functionalities of this plugin because it's really great (but this if for another pull request/ day)

jalvesaq commented 1 month ago

Thank you!

jalvesaq commented 1 month ago

I'm also thinking a bit about other functionalities of this plugin because it's really great (but this if for another pull request/ day)

If something is useful to you it might also help others...