search

jam1garner / binrw

A Rust crate for helping parse and rebuild binary data using ✨macro magic✨.
https://binrw.rs
MIT License
585 stars 35 forks source link

Document the args! macro more thoroughly. #106

Closed kitlith closed 2 years ago

kitlith commented 2 years ago

This macro is a confusing type-system hack, and as pointed out on discord, it kinda needs a "what is this/why is this" comment.

codecov-commenter commented 2 years ago

Codecov Report

Merging #106 (167aaec) into master (c09f9c5) will decrease coverage by 0.08%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #106      +/-   ##
==========================================
- Coverage   67.56%   67.48%   -0.09%     
==========================================
  Files          63       63              
  Lines        3148     3146       -2     
==========================================
- Hits         2127     2123       -4     
- Misses       1021     1023       +2
Impacted Files Coverage Δ
binrw/src/binread/impls.rs 80.85% <ø> (-0.79%) :arrow_down:
binrw/src/builder_types.rs 50.00% <ø> (ø)
binrw_derive/src/lib.rs 86.88% <ø> (ø)
binrw_derive/src/parser/types/magic.rs 88.88% <0.00%> (-5.56%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 66fa257...167aaec. Read the comment docs.