search

jam1garner / owo-colors

A zero-allocation no_std-compatible zero-cost way to add color to your Rust terminal
MIT License
636 stars 33 forks source link

`supports-colors` implicitely required std #88

Open indietyp opened 1 year ago

indietyp commented 1 year ago

The supports-color crate is only available in std environments, owo-colors does not mention that this is the case.

Would it be possible to extend owo-colors feature set to include std, to make this dependency clear via different features?

[features]
std = []
supports-colors = ['std']

Ideally, it'd be great to decouple supports-colors and std further by still having the override present.

This would be beneficial for embedded systems. One could also use build-time environment variables to set the default (like defmt does).

Happy to create a PR!

jam1garner commented 1 year ago

This looks good to me, feel free to submit a PR, let's get this and your other changes in for the upcoming 4.0.0 release