search

jamalex / notion-py

Unofficial Python API client for Notion.so
MIT License
4.3k stars 475 forks source link

Fix for urllib3 retry parameter method_whitelist rename #387

Closed tanoinc closed 1 year ago

tanoinc commented 1 year ago

For the ullib3 Retry func, the parameter method_whitelist was renamed to allowed_methods.

Fix for #386

Can you take a look at it? Sorry for any mistake 🙏

Thanks!

estellerambier commented 1 year ago

I tested your fix in local, it worked 👍

jamalex commented 1 year ago

Thanks!

BruceLee569 commented 7 months ago

@jamalex Packages installed through pip install notion will still report this error, so it is recommended to update pypi and readme.

lukasK9999 commented 7 months ago

It would be nice to set boundary for urllib3 to be >2.0.0 in requirements, cause it will no longer work with older versions