search

jambit / eslint-plugin-typed-redux-saga

These are eslint rules to help with typed-redux-saga
MIT License
17 stars 3 forks source link

Port rules over from eslint-plugin-redux-saga? #4

Open dejesus2010 opened 2 years ago

dejesus2010 commented 2 years ago

Hi there, any chance you can port over the rules in eslint-plugin-redux-saga? Particularly the yield-effect rule.

I just started using redux-saga (well, typed-redux-saga) and I'm finding myself forgetting to prefix effect calls with yield.

dejesus2010 commented 2 years ago

I actually went ahead and added support for this in a PR #5 I just submitted

SantoJambit commented 2 years ago

Hey, while going over the code again, I am a bit confused about the tests for yield-effects. According to the tests, using yield take('ACTION') is okay. Should this not be yield*?

I don't think a rule that only makes sure "yield" is used, makes sense for this project