search

jambonz / helm-charts

helm charts to create a jambonz cluster in Kubernetes
MIT License
6 stars 12 forks source link

Added support for custom user and password for monitoring's postgres database #7

Closed MrFabio closed 1 year ago

MrFabio commented 2 years ago

PostgreSQL database is not customizable, this PR will add support for changing the user and password for the database.

Note: The value for mysql.secret and jwt.secret must be set as a Base64 encoded string which I believe should not be the case as it only matters for the secret creation and the string could be encoded there. I used the same logic for the postgres.user and postgres.secret but it requires to decode it on other files. But changing that makes it a breaking change.

davehorton commented 2 years ago

I'm unclear on something....are you saying this is a breaking change?

MrFabio commented 2 years ago

It is not. I should have been more clearer. If the definition for the secrets for mysql and jwt changed to not be a Base64 string, it would be a breaking change. But the current commit does not interfere with those. That was just a suggestion to reduce the b64dec calls because I used the current logic for the postgres password to use the Base64 as well, which is not optimal.