jambonz / jambonz-infrastructure

packer and cloudformation templates for creating EC2-based jambonz deployments
23 stars 29 forks source link

Feature/add basic auth jaeger #38

Closed ajukes closed 1 year ago

ajukes commented 1 year ago

Vanilla install of Jaeger does not have any security which exposes log data of internal Jambonz cluster open to public.

Using nginx we can secure using basic auth.

Actions taken:

Packer

CloudFormation

ajukes commented 1 year ago

Looks like I was missing the -y switch?

  When you say part of packer where exactly do you mean as this is a packer script?

  From: Dave Horton @.> Sent: 13 January 2023 20:47 To: jambonz/jambonz-infrastructure @.> Cc: Antony Jukes @.>; Author @.> Subject: Re: [jambonz/jambonz-infrastructure] Feature/add basic auth jaeger (PR #38)

  @davehorton commented on this pull request.


In packer/jambonz-web-server/scripts/install_nginx.sh https://github.com/jambonz/jambonz-infrastructure/pull/38#discussion_r1070023850 :

@@ -4,6 +4,9 @@ echo "installing nginx"

 sudo apt-get install -y nginx

+echo "installing apache utils for htpasswd"

+sudo apt-get install apache2-utils

oh sorry, totally misread that. however I tested myself and it didnt work....I think I would prefer the package to be installed as part of the packer

— Reply to this email directly, view it on GitHub https://github.com/jambonz/jambonz-infrastructure/pull/38#discussion_r1070023850 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AFQNFHTNZFA575I7DDDIQJTWSG5NZANCNFSM6AAAAAATZKKHVQ . You are receiving this because you authored the thread.Message ID: @. @.> >

davehorton commented 1 year ago

ah sorry, of course. You're right, this all looks good.