search

jambonz / jambonz-infrastructure

packer and cloudformation templates for creating EC2-based jambonz deployments
23 stars 29 forks source link

JAMBONES_SBCS not found in file jambonz-scalable-production.yaml ecosystem sed script for feature server #76

Closed nitinpo-Kore closed 1 year ago

nitinpo-Kore commented 1 year ago

@davehorton as check with hoan unable to find JAMBONES_SBCS parameter in file jambonz-scalable-production.yaml ecosystem sed script for feature server.. As these was not there in redis fs ently was not getting added after upgrade.

davehorton commented 1 year ago

@nitinpo-Kore @xquanluu This parameter is intentionally not there in the scalable cloudformation. SBCs are dynamically discovered. The IPs are written into redis by sbc-sip-sidecar I believe, and read from there by the feature server

davehorton commented 1 year ago

If you added JAMBONES_SBCS to the ecosystem for a scalable cluster that is a mistake and you should remove it and do a proper investigation

nitinpo-Kore commented 1 year ago

thanks for your reply we have done for mini but i have asked hoan for cluster so he told me that so for confirmation asked you.i hope for cluster its UpToDate.

davehorton commented 1 year ago

https://github.com/jambonz/jambonz-feature-server/blob/1477605e66b4168d198e19baaa22b155d1a1a37b/lib/utils/sbc-pinger.js#L142

That is how the feature server monitors SBCs in a cluster. Not with the JAMBONES_SBCS env var