search

jambonz / realtimedb-helpers

utility functions for querying jambonz redis database
0 stars 9 forks source link

Support for redis sentinel #42

Closed davehorton closed 1 year ago

davehorton commented 1 year ago

For high availability, this package should optionally support connecting to a redis cluster using redis sentinel. Of course, this change must be backwards compatible so that installs can continue choosing to connect to a single redis server using the existing env vars.

In order to support redis sentinel, I believe we will need to remove the dependency on the 'redis' npm package in favor or using ioredis. (Note that ioredis supports Promises natively so this should actually clean up/simplify some of our code).

davehorton commented 1 year ago

Note: following this change it will also be necessary to make similar changes in any other jambonz apps or packages where we are accessing redis directly; however this is the repo with the most changes and is easily tested so let's do this first

xquanluu commented 1 year ago

PR merged and all related product already used latest release, closing this issue