search

jambonz / realtimedb-helpers

utility functions for querying jambonz redis database
0 stars 9 forks source link

Regression: Standard Redis with Auth has been removed from latest version #52

Open ajukes opened 9 months ago

ajukes commented 9 months ago

The following has been removed from the latest code but we still need to support Redis authentication, not just Sentinal.

 // Support legacy app
  if (process.env.JAMBONES_REDIS_USERNAME && process.env.JAMBONES_REDIS_PASSWORD) {
    if (Array.isArray(connectionOpts)) {
      for (const o of opts) {
        o.username = process.env.JAMBONES_REDIS_USERNAME;
        o.password = process.env.JAMBONES_REDIS_PASSWORD;
      }
    } else {
      connectionOpts.username = process.env.JAMBONES_REDIS_USERNAME;
      connectionOpts.password = process.env.JAMBONES_REDIS_PASSWORD;
    }
  }
davehorton commented 9 months ago

@xquanluu please review the history on this change

ajukes commented 4 months ago

Hi guys, still no authentication for standard redis?

if JAMBONES_REDIS_USERNAME & JAMBONES_REDIS_PASSWORD are present, they need to be added to the connectionOpts.

radicaldrew commented 2 weeks ago

I need this also For now I added something like this to it. Should I create a PR?

image