jambonz / sbc-registrar

drachtio app that handles REGISTER requests
MIT License
5 stars 7 forks source link

Registration should forward end-point's IP addess #31

Closed l3nz closed 2 years ago

l3nz commented 2 years ago

It would be nice to have the IP address of the entity trying to register, so that one could implement an APIBAN-style protection.

Now we only get:

{
    "method": "REGISTER",
    "expires": 3600,
    "scheme": "digest",
    "username": "xxxxx",
    "realm": "xxxx.sip.jambonz.us",
    "nonce": "164882756524300",
    "uri": "sip:xxx.sip.jambonz.us",
    "algorithm": "MD5",
    "response": "ee14e3daf59ccb3fa80d3e133fbbb861",
    "qop": "auth",
    "cnonce": "08911326",
    "nc": "00004676"
}

Even better it would be to have the "headers" struct where you have it all, like when a call is started.


    "sip": {
        "headers": {
            "via": "SIP/2.0/UDP 52.55.111.178;rport=5060;branch=z9hG4bK3c113XmS7gcvg;received=xxxx",
            "max-forwards": "70",
            "from": "<sip:31@xxx:5060>;tag=29132U3yS6SZa",
            "to": "<sip:777@xxx.sip.jambonz.us>",
            "call-id": "80d9b6b1-31f3-123b-63a3-0ea24be4d211",
            "X-Forwarded-For": "23.88.37.9",
            "X-Authenticated-User": "....sip.jambonz.us"
            .....

Originally posted as https://github.com/jambonz/jambonz-feature-server/issues/99

davehorton commented 2 years ago

the payload in 0.7.5 will include source_address and source_port