jamcar23 / openpilot

Flexpilot is a fork of openpilot focused on flexibility, live tuning, and other experimental features.
MIT License
3 stars 2 forks source link

OP edit seems broken with lists #81

Closed jamcar23 closed 3 years ago

jamcar23 commented 3 years ago

Discord user duneight got this error when trying to edit indi multi breakpoint source param. At the moment I'm not sure which type of lists / params are broken.

>> Allowed types: list, str >> This parameter supports live tuning! Updates should take effect within 2.5 seconds Current value: ['desired_steer_abs', 'vego'] (type: list) Enter index to edit (0 to 1), or -i to remove index, or +value to append value: >> 0 Current value: desired_steer_abs (type: str) Enter index to edit (0 to 16), or -i to remove index, or +value to append value: >> vego -------- Must be an integar within list range! -------- Current value: desired_steer_abs (type: str) Enter index to edit (0 to 16), or -i to remove index, or +value to append value: >>

jamcar23 commented 3 years ago

Update: according to duneight it only happened on the source param, the other indi multi params worked fine. This means the issue is either 1D lists or, more likely, lists of strings.

It's likely something to do with how 1 & 0 are shortcuts for true and false.