search

james-atkinson / speedcomplainer

A python app that will test your internet connection and then complain to your service provider (and log to a data store if you'd like)
509 stars 106 forks source link

Raspberry Pi Enhancements #13

Open bradleyhurley opened 8 years ago

bradleyhurley commented 8 years ago

Added requirements.txt to avoid confusion (twitter vs python-twitter module) and ease of deployment. Updated ReadMe.md to include pip install requirements.txt Replaced string replace with regex When running speedtest-cli from the Raspberry Pi my output was Mbits/s vs the expect Mbit/s removed hard coded path to speedtest-cli (this allows use with virtualenvs and other distributions)

jbouse commented 8 years ago

Personally I like the enhancements and am looking to merge it into my fork. Curious about the requirements you added as I only had to add 3 into my version that I'm using to deploy on my Raspberry Pi units. I also set mine as minimum versions rather than static versions for pip to install.

bradleyhurley commented 8 years ago

@jbouse - I think you're probably right on the requirements. I will try to update the file this evening.

jbouse commented 8 years ago

@bradleyhurley The other issue I found with your speedcomplainer.py (and it's likely in @james-atkinson version and I just fixed it) is that the file is in CRLF (Windows) not LF (*NIX) format so when I tried to merge your code into mine it generates a big diff because of all the ^M characters.