james-cnz / moodle-format_multitopic

Shows multiple topics per page, with tabbed navigation between pages.
GNU General Public License v3.0
5 stars 7 forks source link

Option to turn off Course Header banner #33

Open bradnielsen2981 opened 1 year ago

bradnielsen2981 commented 1 year ago

James, I'm loving the updated course format.

Quick question: is there an easy way to turn off the Course Header . My Moodle 4.1 Theme is actually rendering the course banner image alongside the Course heading, so I have no need for Multitopic to render a version of it.

regards Brad

james-cnz commented 1 year ago

Hi Brad, There's no setting for this, but you should be able to do it in CSS (one place for this is Site admin > Appearance > Additional HTML > Within HEAD, in a style tag). See issue #18 for some CSS, although where I said display: block; I think this should probably be display: block !important;

bradnielsen2981 commented 1 year ago

Thanks James, I actually ended up just commenting out the render output function for the header. But I think the CSS would be a nicer fix so I can continue to upgrade easily if I just use CSS.

Other than that, I was thinking recently, that it would be nice if a Tab could be exported to become new Course, or it could be used with Sharing Cart to copy over a Section that contains other sections. But I think both these two options would be incredibly difficult to implement.

Well done with the Drag and Drop functionality on the nav menu. I think the only thing left would be the ability to promote a Section using drag and drop. But it works pretty well at present.

regards Brad

Sent from Outlookhttp://aka.ms/weboutlook


From: James C @.> Sent: Monday, 14 November 2022 7:32 AM To: james-cnz/moodle-format_multitopic @.> Cc: Brad Nielsen @.>; Author @.> Subject: Re: [james-cnz/moodle-format_multitopic] Option to turn off Course Header banner (Issue #33)

Hi Brad, There's no setting for this, but you should be able to do it in CSS (one place for this is Site admin > Appearance > Additional HTML > Within HEAD, in a style tag). See issue #18https://github.com/james-cnz/moodle-format_multitopic/issues/18 for some CSS, although where I said display: block; I think this should probably be display: block !important;

— Reply to this email directly, view it on GitHubhttps://github.com/james-cnz/moodle-format_multitopic/issues/33#issuecomment-1312827611, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AJC4HKARG427XXCBBJNFKSDWIFM7JANCNFSM6AAAAAAR65A7XQ. You are receiving this because you authored the thread.Message ID: @.***>

james-cnz commented 1 year ago

Re exporting a tab, or copying a section with subsections in Sharing Cart, I think these are thing that would probably have to be implemented in Moodle itself and Sharing Cart, and I'm not familiar with the code that would need to be modified (or anything much of Moodle code besides my own format and Onetopic).

Re drag and drop, thanks, although of course I had significant help from Jeremy FitzPatrick.

Changing the level of a section via drag and drop wasn't really workable, I think. Moodle's drag and drop system only has the concepts of moving sections before or after another section, so if a section was dragged between two top-level sections, we couldn't distinguish between whether it should be made a top-level section, or the last child of the previous top-level section.

bradnielsen2981 commented 1 year ago

The other thought I had, was that the General Section (Section 0) should be able to be moved, deleted etc. But maybe that too has been locked by Moodle.

regards Brad

Sent from Outlookhttp://aka.ms/weboutlook


From: James C @.> Sent: Monday, 14 November 2022 1:18 PM To: james-cnz/moodle-format_multitopic @.> Cc: Brad Nielsen @.>; Author @.> Subject: Re: [james-cnz/moodle-format_multitopic] Option to turn off Course Header banner (Issue #33)

Re exporting a tab, or copying a section with subsections in Sharing Cart, I think these are thing that would probably have to be implemented in Moodle itself and Sharing Cart, and I'm not familiar with the code that would need to be modified (or anything much of Moodle code besides my own format and Onetopic).

Re drag and drop, thanks, although of course I had significant help from Jeremy FitzPatrick.

Changing the level of a section via drag and drop wasn't really workable, I think. Moodle's drag and drop system only has the concepts of moving sections before or after another section, so if a section was dragged between two top-level sections, we couldn't distinguish between whether it should be made a top-level section, or the last child of the previous top-level section.

— Reply to this email directly, view it on GitHubhttps://github.com/james-cnz/moodle-format_multitopic/issues/33#issuecomment-1313034665, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AJC4HKBSBUR2NWS52HOJRTLWIGVO5ANCNFSM6AAAAAAR65A7XQ. You are receiving this because you authored the thread.Message ID: @.***>

james-cnz commented 1 year ago

Yup, moving or deleting the General section is forbidden by Moodle.