Several improvements - Githubissues

james-fry / hassio-addons

Repository for hass.io add ons

99 stars 96 forks source link

Several improvements #25

Closed bouwew closed 5 years ago

bouwew commented 5 years ago

Hi,

As suggested, I decided to try to create a pull-request :) Changes:

A check was added whether INK provides valid output, or not. When not, no MQTT messages are posted.
Added the file discover.sh to help find the info that needs to be edited into the ink2mqtt.sh
Made the way to add the printer-info into the ink2mqtt.sh a little easier.

bouwew commented 5 years ago

These improvements are for INK2MQTT.

james-fry commented 5 years ago

Thanks @bouwew - your inputs are really appreciated! :) I'll take a look tonight.

james-fry commented 5 years ago

All works well. A nice improvement if I can find time to do it would be what we discussed before: call ink parse out the model and brand + cartridges and then use these to drive mqtt autodiscovery and the periodic mqtt messages For now though this works great.