search

james-nesbitt / wunder-docker

WILL BE RETIRED SOON: Docker boxes for the Wunder app/base based www service
1 stars 2 forks source link

Blackfire should be enabled for php7 images #76

Closed james-nesbitt closed 8 years ago

james-nesbitt commented 8 years ago

Blackfire now supports php7: http://blog.blackfire.io/php7-support-blackfire.html

Our php7 images should enable blackfire probing again.

james-nesbitt commented 8 years ago

A branch has been created for this: https://github.com/james-nesbitt/wunder-docker/tree/php7blackfire

currently I am modifying the php7fpm image to include the blackfire repo, and install the php extension.

james-nesbitt commented 8 years ago

It appears that the blackfire installer (the centos rpm) does not support the REMI php7 library:

================================================================================
 Package               Arch           Version           Repository         Size
================================================================================
Installing:
 blackfire-php         x86_64         1.9.1-1           blackfire         1.1 M

Transaction Summary
================================================================================
Install  1 Package

Total download size: 1.1 M
Installed size: 3.1 M
Downloading packages:
Running transaction check
Running transaction test
Transaction test succeeded
Running transaction
  Installing : blackfire-php-1.9.1-1.x86_64                                 1/1 

We are sorry but we were unable to find any suitable version of Blackfire Probe for your system.
We would like to help you, please contact us on https://blackfire.io using the Feedback button.
OS: Linux f77e60ad5dfc 4.3.4-300.fc23.x86_64 #1 SMP Mon Jan 25 13:39:23 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
Architecture: amd64
PHP ABI version(s) detected: none
PHP ABI version(s) installed: none
PHP extension directory detected: none
PHP extension directory installed: none
PHP configuration directory detected: none

warning: %post(blackfire-php-1.9.1-1.x86_64) scriptlet failed, exit status 1
Non-fatal POSTIN scriptlet failure in rpm package blackfire-php-1.9.1-1.x86_64
  Verifying  : blackfire-php-1.9.1-1.x86_64                                 1/1 

Installed:
  blackfire-php.x86_64 0:1.9.1-1                                                

Complete!

It looks like the package is installed, but the script does not create the php.d/zz-blackfire.ini configuration properly.

I might hack around this with a complete ini file.

james-nesbitt commented 8 years ago

the issue was that the blackfire installer looks for a php ABI by testing the cli version of PHP. We were not installing php-cli in our images.

The solution was to install the cli during install, but then remove it.

james-nesbitt commented 8 years ago

https://github.com/james-nesbitt/wunder-docker/pull/83 resolves this issue