search

james-proxy / james-browser-launcher

Detect, launch and stop browsers
Other
23 stars 15 forks source link

[vsashidh] Issue #49 : internet explorer instance not stopping #10

Closed mitchhentges closed 8 years ago

mitchhentges commented 8 years ago

I'm a little concerned about why the instance wasn't stopping properly. Note that if you run example/launch.js with IE, it shows the following:

$ node launch.js
Instance started with PID: 3168
Instance stopped with exit code: 1
Instance stopped with exit code: 0

What's with the exit code: 1 in the middle? Hmm. (That existed before this PR, it's just curious)

mitchhentges commented 8 years ago

Thanks @vsashidh!

vsashidh commented 8 years ago

Hi Mitchell,

There is a still an issue with re-spawning the ie browser after my code stops the browser. I think it might be a windows thing not allowing for terminating the process. You might want to explore that furhter.

mitchhentges commented 8 years ago

Thanks!