search

james-proxy / james-browser-launcher

Detect, launch and stop browsers
Other
23 stars 15 forks source link

Fix Chrome launch not passed --proxy-server flag. #40

Closed tomitm closed 8 years ago

tomitm commented 8 years ago

Just a typo during 1.2.4 refactoring. Resulted in Chrome never being passed the --proxy-server flag.

mitchhentges commented 8 years ago

:+1:

mitchhentges commented 8 years ago

Maybe move proxy to options.options.proxy? Or is this correct?

tomitm commented 8 years ago

Not 100% sure why it was outside of options.options in the first place, but there's a couple of things like that as well, so it's "correct" in a sense.

Would rather fix the 1.2.4 regression for now and figure out the proper way to sort this out later, since there's a couple of other things on options.

I imagine options.options had a particular purpose when it was originally written.