Open dtanp opened 6 years ago
master
(using win-detect-browsers@1.0.2
)
Available browsers:
[ { name: 'ie',
version: '11.0.17134.1',
type: 'ie',
command: 'C:\\Program Files (x86)\\Internet Explorer\\iexplore.exe' },
{ name: 'ie',
version: '11.0.17134.1',
type: 'ie',
command: 'C:\\Program Files\\Internet Explorer\\iexplore.exe' },
{ name: 'chrome',
version: '68.0.3432.3',
type: 'chrome',
command: 'C:\\Program Files (x86)\\Google\\Chrome\\Application\\chrome.exe' },
{ name: 'chrome',
version: '68.0.3433.0',
type: 'chrome',
command: 'C:\\Users\\tm\\AppData\\Local\\Google\\Chrome SxS\\Application\\chrome.exe' },
{ name: 'firefox',
version: '59.0.2.6656',
type: 'firefox',
command: 'C:\\Program Files\\Mozilla Firefox\\firefox.exe' } ]
This PR (using win-detect-browsers@2.1.0
)
Available browsers:
[ { name: 'chrome',
version: '68.0.3432.3',
type: 'chrome',
command: 'C:\\Program Files (x86)\\Google\\Chrome\\Application\\chrome.exe' },
{ name: 'chrome',
version: '68.0.3433.0',
type: 'chrome',
command: 'C:\\Users\\tm\\AppData\\Local\\Google\\Chrome SxS\\Application\\chrome.exe' },
{ name: 'firefox',
version: '59.0.2.6656',
type: 'firefox',
command: 'C:\\Program Files\\Mozilla Firefox\\firefox.exe' },
{ name: 'ie',
version: '11.0.17134.1',
type: 'ie',
command: 'C:\\Program Files\\Internet Explorer\\iexplore.exe' },
{ name: 'ie',
version: '11.0.17134.1',
type: 'ie',
command: 'C:\\Program Files (x86)\\Internet Explorer\\iexplore.exe' } ]
Windows 10 build 17134.48 (1803). Both versions seem to pick up my Firefox 59 install, although neither detected Firefox 60b Developer Edition. 🤔
Updated both Firefox install to latest versions (60 and 61b):
master
Available browsers:
[ { name: 'chrome',
version: '68.0.3432.3',
type: 'chrome',
command: 'C:\\Program Files (x86)\\Google\\Chrome\\Application\\chrome.exe' },
{ name: 'chrome',
version: '68.0.3433.0',
type: 'chrome',
command: 'C:\\Users\\tm\\AppData\\Local\\Google\\Chrome SxS\\Application\\chrome.exe' },
{ name: 'firefox',
version: '60.0.1.6710',
type: 'firefox',
command: 'C:\\Program Files\\Mozilla Firefox\\firefox.exe' },
{ name: 'ie',
version: '11.0.17134.1',
type: 'ie',
command: 'C:\\Program Files (x86)\\Internet Explorer\\iexplore.exe' },
{ name: 'ie',
version: '11.0.17134.1',
type: 'ie',
command: 'C:\\Program Files\\Internet Explorer\\iexplore.exe' } ]
PR:
Available browsers:
[ { name: 'chrome',
version: '68.0.3433.0',
type: 'chrome',
command: 'C:\\Users\\tm\\AppData\\Local\\Google\\Chrome SxS\\Application\\chrome.exe' },
{ name: 'chrome',
version: '68.0.3432.3',
type: 'chrome',
command: 'C:\\Program Files (x86)\\Google\\Chrome\\Application\\chrome.exe' },
{ name: 'firefox',
version: '60.0.1.6710',
type: 'firefox',
command: 'C:\\Program Files\\Mozilla Firefox\\firefox.exe' },
{ name: 'ie',
version: '11.0.17134.1',
type: 'ie',
command: 'C:\\Program Files (x86)\\Internet Explorer\\iexplore.exe' },
{ name: 'ie',
version: '11.0.17134.1',
type: 'ie',
command: 'C:\\Program Files\\Internet Explorer\\iexplore.exe' } ]
Still not picking up on dev edition. 🤷♂️
For some additional context, see this ticket on win-detect-browsers
FYI I've dusted off win-detect-browsers
. Version 3 is almost ready and has no script files like described in https://github.com/vweevers/win-detect-browsers/issues/29. It does however have native addons, so for electron you need a packager (e.g. Electron Forge) which handles that.
Should be worth it though :)
Also has a fix to detect Firefox Dev.
Thanks @vweevers! I'll keep an eye out for that release. 👀
Fix #71