james-proxy / james-browser-launcher

Detect, launch and stop browsers
Other
23 stars 15 forks source link

Improves quoting on "noProxy" options passed to browsers #74

Closed mitchhentges closed 6 years ago

mitchhentges commented 6 years ago

For Firefox prefs, quotes are needed around strings, such as our list of domains. In the same vein, we don't need to put double-quotes around values with spaces for process arguments if they're already separated into an array, such as the case for Chrome's options.

@mfgea, would you mind confirming that this PR's changes still properly affect the "no-proxy" functionality of Chrome and Firefox?