search

james-proxy / james-browser-launcher

Detect, launch and stop browsers
Other
23 stars 15 forks source link

Does not detect Firefox #83

Open Vaelek opened 5 years ago

Vaelek commented 5 years ago

I have Firefox Quantum 67.0, and it is not being detected. The HTTP Toolkit project uses this module and I came here to find and run it directly to test, and it detects IE twice (x86 and 64) and Opera, but no Firefox. Same results on multiple computers. All Windows 10 Pro

vweevers commented 5 years ago

@Vaelek I think the HTTP Toolkit forked this to https://github.com/httptoolkit/browser-launcher

Vaelek commented 5 years ago

@vweevers I landed here based on this comment from the HTTP Toolkit dev - https://github.com/httptoolkit/feedback/issues/23#issuecomment-485418563 Regardless, the code present in this fork here, as of right now, is not detecting Firefox on 2 machines.

pimterry commented 5 years ago

Since that comment I have indeed forked this, so just I can iterate a bit more directly. Nearly no changes there so far though, and this is an outstanding problem here either way.

Happy to help out with fixing this here instead if that'd be useful, and pull the changes downstream later myself.

I did some investigation, and my best guess so far is that this needs a win-detect-browsers update, since that handles this, and it's very out of date here. Unfortunately that now requires some native modules, so I haven't investigated it myself much as it'd require changes to my build setup, but it would be very interesting to know if you think that's the right approach, or if you have any other routes worth investigating.

vweevers commented 5 years ago

@Vaelek To be sure it's fixed in the latest version of win-detect-browsers, could you test it directly? Like so:

npm i win-detect-browsers --global
win-detect-browsers --summary
Vaelek commented 5 years ago

@vweevers Yes I can confirm that does correctly detect Firefox

mitchhentges commented 5 years ago

Hey all, thanks for the report and potential solution (sounds like win-detect-browsers is still being awesome!)

The team developing James (and, by association, james-browser-launcher) aren't able to commit the same time anymore, so this project is in maintenance mode. httptoolkit's fork sounds like it could probably be a good alternative :smile:

vweevers commented 5 years ago

I suggest moving browser-launcher to a new dedicated github org (or maybe airtap, which is somewhat related). It's easier to invite outside collaborators and ensure continued maintenance when there's no overarching project or company. I could also move win-detect-browsers there if it makes sense.

pimterry commented 5 years ago

This issue is now resolved in the HTTP Toolkit fork, as of v1.4.1.

I suggest moving browser-launcher to a new dedicated github org

That would be great. If there's somebody who wants to properly maintain this as a major project in future, I'd happily deprecate my fork and use that instead.

That said, I'm not that person - I'm happy to fix browser-launcher issues that directly affect my work & projects, so I'll certainly be keeping my fork in an active and usable state that may be useful to others, but I don't have time to go beyond that.