james-proxy / james

Web Debugging Proxy Application
1.42k stars 125 forks source link

On browser-selection, show which browsers don't support auto-proxy-setup #333

Open mitchhentges opened 7 years ago

mitchhentges commented 7 years ago

Currently in master, we warn users that "some browsers" can't be automatically set up to proxy. We should instead just add a ui element to each browser that can't be automatically set up, so users know exactly which browsers require additional configuration.

nerdbeere commented 7 years ago

Maybe we should just show the browsers we can automatically set up? Maybe with a note that other browsers lack this feature.

mitchhentges commented 7 years ago

It makes sense that we should definitely prioritize browsers that we can automatically configure, but I'm worried that if we don't show browsers that we cannot auto-setup, then users will think that James can't work at all with those other browsers.

Perhaps we can have the main list of browsers as we have it today, but that list only has browsers that we can automatically configure. Then, below, as a sub-note, we can show other browsers detected, but have a note saying that the user will manually have to set up the browsers to point to localhost:$port

tomitm commented 6 years ago

Guessing we need to whitelist browsers that support auto configuration.

We can move the unsupported browsers into a separate section below with a wiki link to an explanation. I was thinking of doing something similar for #43 to show a message when we detect HTTPS proxying isn't setup and clearly call it out on the homepage, rather than only vaguely in the footer.