search

james-proxy / james

Web Debugging Proxy Application
1.42k stars 125 forks source link

display response and request body in request details as string #372

Closed formigarafa closed 6 years ago

formigarafa commented 6 years ago

I bashed the minimum to get the response body out in the request details. People from #260 might want to have look.

mitchhentges commented 6 years ago

It looks like we've got some hard build issues right now (including on master). These build issues will need to be resolved to get this PR in. I don't have a ton of time right now to devote to James, but it'd be :100: if you could keep this PR open so it can be merged once the underlying issues have been resolved. Either way, you killed it for a guy who hasn't really worked with React before :smile:

Thram commented 6 years ago

+1 For this.

mitchhentges commented 6 years ago

Ahaa, looking at this a little further, the test failures seem to be localized to this PR. Can you run npm test and, assuming you have the failing tests locally, resolve them?

nerdbeere commented 6 years ago

I'm going to close this one because I opened a new PR with fixed tests (https://github.com/james-proxy/james/pull/377)