Add error messages to 'URL mappings' component

james-proxy / james

Web Debugging Proxy Application

1.42k stars 124 forks source link

Add error messages to 'URL mappings' component #373

Closed jrmykolyn closed 6 years ago

jrmykolyn commented 6 years ago

Proposal: Add error messages to 'URL mappings' component.

Overview: Currently, submitting an empty input field will not allow users to proceed from the 'source' to 'destination' steps of the URL mapping process. However, the UI does not provide any information about why the user is unable to proceed.

If you're interested, I've completed a first pass of this feature and submitted it for review via PR #374 . I'd be happy to receive feedback/direction re: how to get it approved.

jrmykolyn commented 6 years ago

👋 @mitchhentges What do you think about the implementation, and the feature in general?

mitchhentges commented 6 years ago

Hey, sorry, thanks for the PR, and I'm excited to take a look, hopefully this weekend! Work has me busy these days, but it'll be awesome to check it out soon :smile:

jrmykolyn commented 6 years ago

Not a problem, and thanks for your consideration!

jrmykolyn commented 6 years ago

Merged in via #374. Closing.